Commit database after creating oauth_tokens table. Fixes #75 #76
Conversation
|
@hunterji can you also add python 3.6 to tox/travis? |
|
I added py36 to tox.ini |
|
Adding py36 causes TravisCI to fail the checks. Is this because pytest doesn't support Python 3.6 yet? That is why I hadn't added py36 to tox.ini, but I've never used TravisCI so I'm just guessing. |
|
To get TravisCI to play along, you also need to change .travis.yml; it's a good idea to edit that one too. However, it is not the cause of the error that TravisCI is showing:
I'm not sure what exactly requires |
|
Please do only one thing per pull request. That makes it much easier to review & accept. |
|
Cherry-picked original PR in 0556a7e. |
|
I've added Python 3.6 to Tox & Travis in 4e256ab, rewriting how we set up Travis in the first place. Before this commit, Travis multiplied the Python versions with the environments, and ran the tests for each combination. The new approach sets things up correctly, matching Python version with TOXENV variable. |
This change seems to be required in Python 3.6.0. It works correctly without the db.commit() in 3.5.2 and earlier. Without the commit the first table, oauth_cache_db_version, gets created, but oauth_tokens does not.
I ran the unit tests on 3.5.2 after making the change and all passed. I couldn't run them on 3.6.0 because pytest isn't supported there yet. I did make the change and test manually in 3.6.0. All tests were on Windows 10.